Hi,<br><br><div class="gmail_quote">On Thu, Aug 30, 2012 at 9:17 AM, Szilárd Páll <span dir="ltr"><<a href="mailto:szilard.pall@cbr.su.se" target="_blank">szilard.pall@cbr.su.se</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
Commit 26bd5f7 added a the admin/.isreposource file to distinguish git<br>
and non-git source trees. As far as I know git repositories will<br>
always contain the .git directory, so I think it is enough to check<br>
the existence of this (as it is done in<br>
cmake/gmxGenerateVersionInfo.cmake).<br>
<br>
Is there any strong reason for having an extra file for this simple check?<br></blockquote><div>Yes. If you download the source as archive (e.g. from github) you will get the source not from cpack but it won't contain .git. We want to distinguish with this file whether the source is directly from the git sources without having been processed by cpack. That's why this file is required.</div>
<div><br></div><div>Roland</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
--<br>
Szilárd<br>
<span class="HOEnZb"><font color="#888888">--<br>
gmx-developers mailing list<br>
<a href="mailto:gmx-developers@gromacs.org">gmx-developers@gromacs.org</a><br>
<a href="http://lists.gromacs.org/mailman/listinfo/gmx-developers" target="_blank">http://lists.gromacs.org/mailman/listinfo/gmx-developers</a><br>
Please don't post (un)subscribe requests to the list. Use the<br>
www interface or send it to <a href="mailto:gmx-developers-request@gromacs.org">gmx-developers-request@gromacs.org</a>.<br>
<br>
<br>
<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov">cmb.ornl.gov</a><br>865-241-1537, ORNL PO BOX 2008 MS6309<br>