<br><br><div class="gmail_quote">On Wed, Mar 6, 2013 at 2:40 PM, Shirts, Michael (mrs5pt) <span dir="ltr"><<a href="mailto:mrs5pt@eservices.virginia.edu" target="_blank">mrs5pt@eservices.virginia.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> Code reviewing can be sped up by adding reviewers. The person that<br>
> submits a gerrit patch usually has a decent idea of who might know the<br>
> code sufficiently well to review it. We should however share the load<br>
> and not dump everything on e.g. Berk. I usually add two to three people<br>
> to patches, which means they get mail at least once.<br>
<br>
</div>This is something I struggle with -- I don't always know who to add. Berk<br>
knows integrators and free energy, Sander knows free energies . . . And I<br>
don't know who else.<br>
<br>
So if we had some sort of list of who could review on what subject, that<br>
might be good.<br></blockquote><div><br></div><div>Sounds good to me. I'd suggest we'd need some kind of table where people have a name, a list of topics they're interested to review, and a list of topics they know they can't/won't review. Ideally, Gerrit would present a link to that page so that people can browse it when they have added a new patch. Not sure how feasible that is. Wanting anybody to be able to edit their own information makes it feel more like wiki content than Redmine content to me, so I'd suggest a new subsection of <a href="http://www.gromacs.org/Developer_Zone/Git/Gerrit">http://www.gromacs.org/Developer_Zone/Git/Gerrit</a>. Any further thoughts?</div>
<div><br></div><div>Mark</div></div>