<p dir="ltr">Feel free to add types you need; that should be trivial. The current list simply includes those currently used; there is no other reason for leaving things out.</p>
<p dir="ltr">The original reason for the different enumeration was that the code in filenm.* was not reusable enough. That is no longer the case, but the separate enumeration still makes sense to provide understandable names for the file types. The types of file options may not always coincide 1-to-1 to actual file types (the existing ef??X types are one example), and this additional enumeration provides this abstraction.</p>
<div class="gmail_quote">On Nov 8, 2013 2:47 PM, "David van der Spoel" <<a href="mailto:spoel@xray.bmc.uu.se">spoel@xray.bmc.uu.se</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
I'm trying to implement new analysis tools using Teemu's framework. For some reason this only supports a subset of all gromacs files, and uses new enumerated types to distinguish them. E.g.:<br>
<br>
options->addOption(<u></u>FileNameOption("sfac").<u></u>filetype(eftGenericData)<br>
.inputFile().required()<br>
.store(&fnSfactor_).<u></u>defaultBasename("sfactor")<br>
.description("Structure factors"));<br>
<br>
I would like this file to have the .xml extension, however in options/filenameoption.cpp we only have:<br>
<br>
FileTypeRegistry::<u></u>FileTypeRegistry()<br>
{<br>
filetypes_.resize(<u></u>eftOptionFileType_NR);<br>
registerType(eftTopology, efTPS);<br>
registerType(eftTrajectory, efTRX);<br>
registerType(eftPDB, efPDB);<br>
registerType(eftIndex, efNDX);<br>
registerType(eftPlot, efXVG);<br>
registerType(eftGenericData, efDAT);<br>
}<br>
<br>
note that the eftXXX are different from efXXX in fileio/filenm.h.<br>
<br>
Main question therefore is:<br>
Why would we not allow all the old field types?<br>
<br>
-- <br>
David van der Spoel, Ph.D., Professor of Biology<br>
Dept. of Cell & Molec. Biol., Uppsala University.<br>
Box 596, 75124 Uppsala, Sweden. Phone: <a href="tel:%2B46184714205" value="+46184714205" target="_blank">+46184714205</a>.<br>
<a href="mailto:spoel@xray.bmc.uu.se" target="_blank">spoel@xray.bmc.uu.se</a> <a href="http://folding.bmc.uu.se" target="_blank">http://folding.bmc.uu.se</a><br>
-- <br>
gmx-developers mailing list<br>
<a href="mailto:gmx-developers@gromacs.org" target="_blank">gmx-developers@gromacs.org</a><br>
<a href="http://lists.gromacs.org/mailman/listinfo/gmx-developers" target="_blank">http://lists.gromacs.org/<u></u>mailman/listinfo/gmx-<u></u>developers</a><br>
Please don't post (un)subscribe requests to the list. Use the www interface or send it to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@<u></u>gromacs.org</a>.<br>
</blockquote></div>