<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi,<div><br><div><div>On 18 Nov 2013, at 16:23, Mark Abraham <<a href="mailto:mark.j.abraham@gmail.com">mark.j.abraham@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<div>
<div dir="ltr">Looks like a good start! Thanks.
</div></div></blockquote><div><br></div>Yes indeed!</div><div><br><blockquote type="cite"><div><div dir="ltr"><div><br>
</div>
<div>I'm not sure whether <span style="font-size:13px;font-family:arial,sans-serif"><gromacs xmlns:gmx="</span><a href="http://www.gromacs.org/schemas" target="_blank" style="font-size:13px;font-family:arial,sans-serif">http://www.gromacs.<u></u>org/schemas</a><span style="font-size:13px;font-family:arial,sans-serif">">
should name a schema file, or a place to look up a schema file. Does anyone know? In the past I have seem XML files with namespace-specific content like</span></div></div></div></blockquote><div><br></div>Formally it does not have to point to anything, IIRC; the only requirement is that it is a UUID (universal unique identifier) for each individual schema (thus, no common web page). However, I think it makes a lot of sense to make it point to an actual schema file, but since this is likely to be a quick/transient/temporary solution I also think it’s a good idea to create a special namespace (and schema) for it, rather than using the default “gromacs” name (since that will clobber all future usage)?</div><div><br></div><div><blockquote type="cite"><div><div dir="ltr">
<div><span style="font-size:13px;font-family:arial,sans-serif"><br>
</span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px"> <gmx:sfactors type="Fourier" force_field="any" displaced_solvent="true" reference=""></span><br style="font-family:arial,sans-serif;font-size:13px">
<font face="arial, sans-serif" size="2"> <gmx:sfactor residue="ALA" atom="MW" type="1”></font><br style="font-family:arial,sans-serif;font-size:13px"></div></div></div></blockquote><br></div><div>A couple of minor things:</div><div><br></div><div>* Since we’re moving to C++, should we use camelcase for new files? I also think we should write out names for clarity - in particular when we only use them a handful of times. In other words, I prefer “StructureFactor” over sfactor, etc. Readability rocks :-)</div><div><br></div><div>* When it comes to the type of structure factor, to me it looks as if this is specific to electronic structure factors (or will it work for neutrons or other stuff too?). In that case we should probably encode that!</div><div><br></div><div>* Units are great, although I would use “^-1” to denote each reciprocal component. That way we might have a chance of creating an automatic parsing in the future.</div><div><br></div><div>* Rather than doing “type=1”, what does the type mean here? It seems to be a different sort of “type” from the same field on the preceding line.</div><div><br></div><div>* To me it sounds _very_ bold to claim that a file will work for “any” force field. Will it really be applicable both to all-atom, united-atom and CG force fields of all kinds? If not, I think it should be FF-specific (just like we have copies of many other files in lots of directories)</div><div><br></div><div>* Not sure if this is complicated, but would it be possible to encode the order of each factor through an attribute rather than introducing new XML tags for each of them?</div><div><br></div><div>* Finally, to try and help rather than nitpicking about specific fields: David, perhaps you do a high-level description about the things you want to encode, and what choices we need for that? What choices are allowed in different parts?</div><div><br></div><div><br></div><div>Cheers,</div><div><br></div><div>Erik</div><div><br></div><div><br></div><div><br></div><br></div></body></html>