<div dir="ltr">Hi,<div><br></div><div>Patch set 2 tries to cover all the files that #include gtest/gmock. I'd prefer to use a scalpel rather than a sledgehammer if we can. Any chance of a verbose-mode console log, please?</div>
<div><br></div><div>Mark</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 28, 2014 at 10:29 PM, Mirco Wahab <span dir="ltr"><<a href="mailto:mirco.wahab@chemie.tu-freiberg.de" target="_blank">mirco.wahab@chemie.tu-freiberg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On 28.06.2014 19:16, Mark Abraham wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
a) Visual C++ doesn't support variadic templates, so gmock/gtest<br>
will fail. Adding /D_VARIADIC_MAX=10 to CMAKE_CXX_FLAGS solves this<br></div>
(<a href="http://stackoverflow.com/__questions/12558327/google-__test-in-visual-studio-2012" target="_blank">http://stackoverflow.com/__<u></u>questions/12558327/google-__<u></u>test-in-visual-studio-2012</a><br>
<<a href="http://stackoverflow.com/questions/12558327/google-test-in-visual-studio-2012" target="_blank">http://stackoverflow.com/<u></u>questions/12558327/google-<u></u>test-in-visual-studio-2012</a>>).<br>
</blockquote><div class="">
<br>
Thanks for the report. I have uploaded <a href="https://gerrit.gromacs.org/3717" target="_blank">https://gerrit.gromacs.org/<u></u>3717</a><br>
to fix this.<br>
</div></blockquote>
<br>
This doesn't seem to work properly. I installed git and fetched 3717/2<br>
but the change of the cmake file in the gmock directory only doesn't<br>
seem enough. There are still plenty of error messages, probably from<br>
wherever gtest/gmock is included.<br>
<br>
<br>
If I add /D_VARIADIC_MAX=10 to the root CMakeLists.txt, all works fine.<br>
<br>
Regards<div class="HOEnZb"><div class="h5"><br>
<br>
M.<br>
<br>
<br>
-- <br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" target="_blank">http://www.gromacs.org/<u></u>Support/Mailing_Lists/GMX-<u></u>developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" target="_blank">http://www.gromacs.org/<u></u>Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" target="_blank">https://maillist.sys.kth.se/<u></u>mailman/listinfo/gromacs.org_<u></u>gmx-developers</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@<u></u>gromacs.org</a>.<br>
</div></div></blockquote></div><br></div>