<div dir="ltr">Hi,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 25, 2014 at 5:26 PM, Jan Henning Peters <span dir="ltr"><<a href="mailto:jpeters@gwdg.de" target="_blank">jpeters@gwdg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Since my last rebase, I noticed a change in the handling of default<br>
filenames that I believe might be unintended.<br>
<br>
As far as I can see, the FileNameOption class only has a method<br>
defaultBasename (attempting to call defaultValue results in a compiler<br>
error), which does not allow supplying a file extension - if a<br>
"filename.ext" is given, this is taken as the basename, and a standard<br>
file extension is appended. The default file extension is then appended<br>
by the framework based on the filetype set. Unfortunately,<br>
eftTrajectory for example this limits the default filetype to .xtc -<br>
setting a .trr or .pdb file as default output is not possible any more<br>
for the developer.<br></blockquote><div><br></div><div>If that ever worked with FileNameOption, it was purely unintentional. ;) As the name of the method suggests, it is meant for specifying the base name, and there never has been a method to do anything else. I now added one in <<a href="https://gerrit.gromacs.org/#/c/3826/">https://gerrit.gromacs.org/#/c/3826/</a>>.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">There seems to be a similar problem even with the older modules, I<br>
noticed that gmx covar now by default produces a file named average.pdb.gro.<br></blockquote><div><br></div><div>That is also fixed in the above change. I hadn't noticed that although ~95% of the t_filenm declarations only specified the default base name, the remaining ~5% had an extension, which was not handled properly. Of those 5%, 80% only specified the default extension, though, so to make the code use the same approach everywhere, I removed those cases in <<a href="https://gerrit.gromacs.org/#/c/3825/">https://gerrit.gromacs.org/#/c/3825/</a>>. The remaining 1% should be properly working as well after these changes are merged.</div>
<div><br></div><div>Best regards,</div><div>Teemu</div></div></div></div>