<div dir="ltr">Hi,<div><br>I think we also need to do something about the "Not enough memory." errors with which the MdrunTests sometimes fails. It is currently probably one of the leading causes of false positives. Example: <a href="http://jenkins.gromacs.org/job/Gromacs_Gerrit_5_0/958/">http://jenkins.gromacs.org/job/Gromacs_Gerrit_5_0/958/</a>. Not sure if it is enough to increase the memory or decrease the number of jobs executed in parallel.</div><div><br></div><div>Roland</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 18, 2014 at 5:55 PM, Mark Abraham <span dir="ltr"><<a href="mailto:mark.j.abraham@gmail.com" target="_blank">mark.j.abraham@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote"><span class="">On Thu, Sep 18, 2014 at 8:09 PM, Roland Schulz <span dir="ltr">
<<a href="mailto:roland@utk.edu" target="_blank">roland@utk.edu</a>></span> wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Hi,
<div><br>
</div><span class="">
<div>I suggest we change the gerrit setting <a href="http://change.largeChange" target="_blank">change.largeChange</a> from 500 to 1000 (at what point the size bar is red).</div>
</span></div>
</blockquote>
<div><br>
</div>
<div>Sounds good for the forseeable future. Not sure where it is - if you know, please do it.</div><span class="">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div>Also I think we should try harder to break changes into small easy reviewable patches. Changes such as: <a href="https://gerrit.gromacs.org/#/c/3471" target="_blank">https://gerrit.gromacs.org/#/c/3471</a> are too big to be reviewed efficiencly.</div>
</div>
</blockquote>
<div><br>
</div>
</span><div>True, but it'd be nice also if we were all a little more cooperative with reviewing low-impact patches (e.g. clean up or file renaming that doesn't change functionality) so that people aren't tempted to write monolithic patches (where, when their ship
comes in, they all come in at once...). For example, having gone a fair way into development of 3471, David might recognize that he could split that patch into</div>
<div>1. move the existing functionality into the newly named files, get most of the tools to call it from the new place in the old way</div>
<div>2. import lmfit, change existing functionality to use it, add tests</div>
<div>3. any genuinely new stuff (if any; not apparent to me right now)</div>
<div><br>
</div>
<div>Patch 1 ought to be easy and fast to review (no functional changes), and patch 2 should be faster to review than 1+2 altogether. Today, I did some review on "new-seeming" code in 3471 that upon closer inspection was just old code moved to a new file -
had I submitted that part of my review, David would likely have had to say "well, sure, but that's not code I wrote, or that I'm working on here." The split of 1 & 2 would make that clear to reviewers up front.</div>
<div><br>
</div>
<div>That said, I've had poor experiences with (say) <a href="https://gerrit.gromacs.org/#/q/topic:g-tune-pme-reform" target="_blank">https://gerrit.gromacs.org/#/q/topic:g-tune-pme-reform</a>, where people have reviewed some changes and not enough people have reviewed their
pre-reqs, etc. I have a bunch more (IMO) decently atomic commits for fixing tune-pme sitting in a long-forgotten repo on a drive... I can't say <a href="https://gerrit.gromacs.org/#/q/topic:bondeds" target="_blank">https://gerrit.gromacs.org/#/q/topic:bondeds</a> has been
a compelling experience, either. I don't mean this as criticism of any one or any group - but I do think that with more than 100 outstanding patches in Gerrit and a long-time-average merge rate of about 2 per day (<a href="https://gerrit.gromacs.org/#/q/project:gromacs+status:merged" target="_blank">https://gerrit.gromacs.org/#/q/project:gromacs+status:merged</a>),
we all need to pitch in harder with review and review-response, and less on doing our own cool new things.</div><span class="HOEnZb"><font color="#888888">
<div><br>
</div>
<div>Mark</div></font></span><div><div class="h5">
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div>Roland</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote"><span>On Mon, Sep 15, 2014 at 9:20 AM, Mark Abraham
<span dir="ltr"><<a href="mailto:mark.j.abraham@gmail.com" target="_blank">mark.j.abraham@gmail.com</a>></span> wrote:<br>
</span>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div dir="ltr">Hi,
<div><br>
</div>
<div><span>We now have gerrit 2.9.1 deployed, and bs_mac upgraded to Mavericks and XCode 5.1. Everything should be usable, do yell if not! If bs_mac + icc still misbehaves then we'll bump icc version or something.<br>
</span>
<div class="gmail_extra"><br>
<div class="gmail_quote"><span><span>On Sun, Sep 14, 2014 at 7:32 PM, Roland Schulz
<span dir="ltr"><<a href="mailto:roland@utk.edu" target="_blank">roland@utk.edu</a>></span> wrote:<br>
</span><span>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Hi,
<div><br>
</div>
<div>we could install Gerrit-Trigger Jenkins-plugin 2.12-beta. It fixes the issue that the matrix job isn't canceled when a newer change is uploaded: <a href="https://issues.jenkins-ci.org/browse/JENKINS-24295" target="_blank">https://issues.jenkins-ci.org/browse/JENKINS-24295</a></div>
<div>We would need to build it ourselves because 2.12-beta-5 which will include the patch isn't out yet. Let me know - it should be easy for me to build it.</div>
</div>
</blockquote>
<div><br>
</div>
</span></span><span>
<div>Sounds good. I am out of time for this today, but if you can build it then we can deploy it without taking gerrit down.</div>
<span><font color="#888888">
<div><br>
</div>
<div>Mark</div>
<div><br>
</div>
</font></span></span>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><span>
<div dir="ltr">
<div>Roland</div>
</div>
<div class="gmail_extra"><span><br>
<div class="gmail_quote">On Sat, Sep 13, 2014 at 7:28 AM, Mark Abraham <span dir="ltr">
<<a href="mailto:mark.j.abraham@gmail.com" target="_blank">mark.j.abraham@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div dir="ltr">Hi,
<div><br>
</div>
<div>The Jenkins Mac build slave needs an OS upgrade to keep up with Xcode versions, which we hope will fix the way the mac+icc CI build segfaults occasionally. Rossen's going to do that on Monday. There's a newer Gerrit version out that has a bug fix that
I'm keen to use, so I'll also upgrade Gerrit on Monday so we have less overall downtime. Jenkins and Redmine are probably OK for now. We should bump our icc versions, but we don't need a downtime for that. Anything else people can think of we should fix?</div>
<span><font color="#888888">
<div><br>
</div>
<div>Mark</div>
</font></span></div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
</span><span><font color="#888888">-- <br>
ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov" target="_blank">
cmb.ornl.gov</a><br>
<a href="tel:865-241-1537" value="+18652411537" target="_blank">865-241-1537</a>, ORNL PO BOX 2008 MS6309
</font></span></div>
<br>
</span></span><span><span>--<br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to
<a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.<br>
</span></span></blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<span>
<div><br>
</div>
-- <br>
ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov" target="_blank">
cmb.ornl.gov</a><br>
<a href="tel:865-241-1537" value="+18652411537" target="_blank">865-241-1537</a>, ORNL PO BOX 2008 MS6309 </span></div>
<br>
--<br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to
<a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.<br>
</blockquote>
</div></div></div>
<br>
</div>
</div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov">cmb.ornl.gov</a><br>865-241-1537, ORNL PO BOX 2008 MS6309
</div>