<div dir="ltr"><div><font face="arial, helvetica, sans-serif">Hi,</font></div><div><font face="arial, helvetica, sans-serif"><br></font></div><div><font face="arial, helvetica, sans-serif">a few more numbers. Maybe we can encourage more review by acknowledging each other more for doing review. In that spirit I want to thank Teemu for being the reviewer of the month October for most review comments:</font></div><div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace">select FULL_NAME, count(*) as messages from CHANGE_MESSAGES as m, CHANGES as c, accounts as a where account_id=AUTHOR_ID and c.CHANGE_ID=m.CHANGE_ID and AUTHOR_ID<>OWNER_ACCOUNT_ID and month(m.WRITTEN_ON)=10 and year(m.WRITTEN_ON)=2014 group by FULL_NAME order by messages desc;</font></div><div><font face="courier new, monospace"> FULL_NAME | MESSAGES</font></div><div><font face="courier new, monospace"> --------------------+---------</font></div><div><font face="courier new, monospace"> Jenkins Buildbot | 253</font></div><div><font face="courier new, monospace"> Teemu Murtola | 80</font></div><div><font face="courier new, monospace"> Roland Schulz | 54</font></div><div><font face="courier new, monospace"> Szilárd Páll | 35</font></div><div><font face="courier new, monospace"> Mark Abraham | 35</font></div><div><font face="courier new, monospace"> Berk Hess | 32</font></div><div><font face="courier new, monospace"> Carsten Kutzner | 9</font></div><div><font face="courier new, monospace"> David van der Spoel | 8</font></div><div><font face="courier new, monospace"> Jiri Kraus | 7</font></div><div><font face="courier new, monospace"> Rossen Apostolov | 5</font></div><div><font face="courier new, monospace"> Erik Lindahl | 4</font></div><div><font face="courier new, monospace"> Thomas Ullmann | 4</font></div><div><font face="courier new, monospace"> Christian Wennberg | 1</font></div><div><font face="courier new, monospace"> Viveca Lindahl | 1</font></div><div><font face="courier new, monospace"> John Eblen | 1</font></div><div><font face="courier new, monospace"> Justin Lemkul | 1</font></div><div><font face="courier new, monospace">(16 rows; 339 ms)</font></div><div><font face="courier new, monospace"><br></font></div><div><font face="arial, helvetica, sans-serif">In the last 90 days we did pretty well have having an OK ratio of review votes to commits created. Largely because Mark did a lot of reviewing for all of us:</font></div><div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace">select full_name, reviewed, authored, round(cast(reviewed as float)/authored,2) as ratio from accounts a left JOIN</font></div><div><font face="courier new, monospace">(select OWNER_ACCOUNT_ID as ACCOUNT_ID, count(*) as authored from Changes where status<>'d' and DEST_PROJECT_NAME='gromacs' and now()-created_on<90 group by ACCOUNT_ID) C</font></div><div><font face="courier new, monospace">ON A.ACCOUNT_ID=C.ACCOUNT_ID left join</font></div><div><font face="courier new, monospace">(select ACCOUNT_ID, count(distinct c.CHANGE_ID) as reviewed from PATCH_SET_APPROVALS as P,Changes as C where CATEGORY_ID='Code-Review' and C.change_id=P.change_id and p.ACCOUNT_ID<>OWNER_ACCOUNT_ID and VALUE!=0 and DEST_PROJECT_NAME='gromacs' and now()-granted<90 group by ACCOUNT_ID) R</font></div><div><font face="courier new, monospace">ON R.ACCOUNT_ID=A.ACCOUNT_ID where authored is not null or reviewed is not null order by ratio, authored;</font></div><div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace"> FULL_NAME | REVIEWED | AUTHORED | RATIO</font></div><div><font face="courier new, monospace"> --------------------+----------+----------+------</font></div><div><font face="courier new, monospace"> Alexey Shvetsov | 1 | NULL | NULL</font></div><div><font face="courier new, monospace"> Paul van Maaren | 1 | NULL | NULL</font></div><div><font face="courier new, monospace"> Thomas Ullmann | 4 | NULL | NULL</font></div><div><font face="courier new, monospace"> Christian Wennberg | 2 | NULL | NULL</font></div><div><font face="courier new, monospace"> John Eblen | 2 | NULL | NULL</font></div><div><font face="courier new, monospace"> Jeroen Engelberts | NULL | 1 | NULL</font></div><div><font face="courier new, monospace"> Åke Sandgren | NULL | 1 | NULL</font></div><div><font face="courier new, monospace"> Jiri Kraus | NULL | 1 | NULL</font></div><div><font face="courier new, monospace"> Christoph Junghans | NULL | 2 | NULL</font></div><div><font face="courier new, monospace"> Rossen Apostolov | 1 | 10 | 0.1</font></div><div><font face="courier new, monospace"> Magnus Lundborg | 3 | 5 | 0.6</font></div><div><font face="courier new, monospace"> Teemu Murtola | 58 | 75 | 0.77</font></div><div><font face="courier new, monospace"> Jan Henning Peters | 1 | 1 | 1.0</font></div><div><font face="courier new, monospace"> Berk Hess | 24 | 22 | 1.09</font></div><div><font face="courier new, monospace"> Roland Schulz | 85 | 65 | 1.31</font></div><div><font face="courier new, monospace"> Erik Lindahl | 21 | 15 | 1.4</font></div><div><font face="courier new, monospace"> Justin Lemkul | 6 | 4 | 1.5</font></div><div><font face="courier new, monospace"> Carsten Kutzner | 7 | 4 | 1.75</font></div><div><font face="courier new, monospace"> Viveca Lindahl | 2 | 1 | 2.0</font></div><div><font face="courier new, monospace"> David van der Spoel | 22 | 9 | 2.44</font></div><div><font face="courier new, monospace"> Mark Abraham | 137 | 40 | 3.43</font></div><div><font face="courier new, monospace"> Szilárd Páll | 26 | 5 | 5.2</font></div><div><font face="courier new, monospace">(22 rows; 3460 ms)</font></div><div><font face="courier new, monospace"><br></font></div><div><font face="arial, helvetica, sans-serif">But the same query for the last 30 days shows that we now all have less than 2 review votes per change created. That isn't sustainable if we want to keep our policy of 2 votes per commit. </font></div><div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace">select full_name, reviewed, authored, round(cast(reviewed as float)/authored,2) as ratio from accounts a left JOIN</font></div><div><font face="courier new, monospace">(select OWNER_ACCOUNT_ID as ACCOUNT_ID, count(*) as authored from Changes where status<>'d' and DEST_PROJECT_NAME='gromacs' and now()-created_on<30 group by ACCOUNT_ID) C</font></div><div><font face="courier new, monospace">ON A.ACCOUNT_ID=C.ACCOUNT_ID left join</font></div><div><font face="courier new, monospace">(select ACCOUNT_ID, count(distinct c.CHANGE_ID) as reviewed from PATCH_SET_APPROVALS as P,Changes as C where CATEGORY_ID='Code-Review' and C.change_id=P.change_id and p.ACCOUNT_ID<>OWNER_ACCOUNT_ID and VALUE!=0 and DEST_PROJECT_NAME='gromacs' and now()-granted<30 group by ACCOUNT_ID) R</font></div><div><font face="courier new, monospace">ON R.ACCOUNT_ID=A.ACCOUNT_ID where authored is not null or reviewed is not null order by ratio, authored;</font></div><div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace"> FULL_NAME | REVIEWED | AUTHORED | RATIO</font></div><div><font face="courier new, monospace"> --------------------+----------+----------+------</font></div><div><font face="courier new, monospace"> Thomas Ullmann | 4 | NULL | NULL</font></div><div><font face="courier new, monospace"> Christian Wennberg | 1 | NULL | NULL</font></div><div><font face="courier new, monospace"> John Eblen | 2 | NULL | NULL</font></div><div><font face="courier new, monospace"> Jeroen Engelberts | NULL | 1 | NULL</font></div><div><font face="courier new, monospace"> Magnus Lundborg | NULL | 1 | NULL</font></div><div><font face="courier new, monospace"> Jiri Kraus | NULL | 1 | NULL</font></div><div><font face="courier new, monospace"> Teemu Murtola | 13 | 22 | 0.59</font></div><div><font face="courier new, monospace"> Viveca Lindahl | 1 | 1 | 1.0</font></div><div><font face="courier new, monospace"> Szilárd Páll | 1 | 1 | 1.0</font></div><div><font face="courier new, monospace"> Justin Lemkul | 1 | 1 | 1.0</font></div><div><font face="courier new, monospace"> David van der Spoel | 2 | 2 | 1.0</font></div><div><font face="courier new, monospace"> Roland Schulz | 19 | 17 | 1.12</font></div><div><font face="courier new, monospace"> Mark Abraham | 8 | 6 | 1.33</font></div><div><font face="courier new, monospace"> Carsten Kutzner | 3 | 2 | 1.5</font></div><div><font face="courier new, monospace"> Berk Hess | 9 | 6 | 1.5</font></div><div><font face="courier new, monospace">(15 rows; 3482 ms)</font></div><div class="gmail_extra"><br></div><div class="gmail_extra">I of course don't suggest that everyone needs to have a ratio over 2 (the numbers don't capture that some changes are trivial and other are difficult to review or any other aspects related to size, complexity, and quality). But we do need the ratio over 2 in average and thus need to do something so that we all do some more reviews.<br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><font face="arial, helvetica, sans-serif">Roland</font></div><div class="gmail_extra"><font face="courier new, monospace"><br></font><div class="gmail_quote"><font face="courier new, monospace">On Sat, Nov 1, 2014 at 1:35 AM, Schulz, Roland <span dir="ltr"><<a href="mailto:rschulz3@vols.utk.edu" target="_blank">rschulz3@vols.utk.edu</a>></span> wrote:<br></font><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr"><font face="courier new, monospace"><br>
</font><div class="gmail_extra"><font face="courier new, monospace"><br>
</font><div class="gmail_quote"><font face="courier new, monospace"><span class="">On Sat, Nov 1, 2014 at 12:17 AM, Teemu Murtola <span dir="ltr">
<<a href="mailto:teemu.murtola@gmail.com" target="_blank">teemu.murtola@gmail.com</a>></span> wrote:<br>
</span><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div dir="ltr">Interesting graph. I assume that the number of changes is the number of new created changes.
</div>
</div>
</blockquote>
</span></font><div><font face="courier new, monospace">yes </font></div><span class=""><font face="courier new, monospace">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div dir="ltr">It might also be interesting to to include the number of changes that were resolved (merged, abandoned, deleted), and possibly the average in-flight time (from initial upload to resolution) of a change. Not sure how easy the latter is to calculate
from available data or to present in the same graph, but these could be useful to get an idea of what one can expect for new changes.<br>
</div>
</div>
</blockquote>
<div><br>
</div>
</font></span><div><div class="h5"><div><font face="courier new, monospace">The average number of days it took from a change to be created until it was merged:</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div><font face="courier new, monospace">select avg(m.WRITTEN_ON-c.CREATED_ON),month(m.WRITTEN_ON) as month, year(m.WRITTEN_ON) as year from changes as c, change_messages as m where c.CHANGE_ID=m.CHANGE_ID and c.STATUS='M' and m.message like 'Change has been successfully%' group by month,year
order by year,month;</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace"> AVG(DATEDIFF('DAY', C.CREATED_ON, M.WRITTEN_ON)) | MONTH | YEAR</font></div>
<div><font face="courier new, monospace"> -------------------------------------------------+-------+-----</font></div>
<div><font face="courier new, monospace"> 1 | 8 | 2011</font></div>
<div><font face="courier new, monospace"> 2 | 9 | 2011</font></div>
<div><font face="courier new, monospace"> 14 | 10 | 2011</font></div>
<div><font face="courier new, monospace"> 9 | 11 | 2011</font></div>
<div><font face="courier new, monospace"> 15 | 12 | 2011</font></div>
<div><font face="courier new, monospace"> 6 | 1 | 2012</font></div>
<div><font face="courier new, monospace"> 14 | 2 | 2012</font></div>
<div><font face="courier new, monospace"> 4 | 3 | 2012</font></div>
<div><font face="courier new, monospace"> 3 | 4 | 2012</font></div>
<div><font face="courier new, monospace"> 3 | 5 | 2012</font></div>
<div><font face="courier new, monospace"> 7 | 6 | 2012</font></div>
<div><font face="courier new, monospace"> 10 | 7 | 2012</font></div>
<div><font face="courier new, monospace"> 4 | 8 | 2012</font></div>
<div><font face="courier new, monospace"> 6 | 9 | 2012</font></div>
<div><font face="courier new, monospace"> 11 | 10 | 2012</font></div>
<div><font face="courier new, monospace"> 7 | 11 | 2012</font></div>
<div><font face="courier new, monospace"> 11 | 12 | 2012</font></div>
<div><font face="courier new, monospace"> 7 | 1 | 2013</font></div>
<div><font face="courier new, monospace"> 10 | 2 | 2013</font></div>
<div><font face="courier new, monospace"> 19 | 3 | 2013</font></div>
<div><font face="courier new, monospace"> 28 | 4 | 2013</font></div>
<div><font face="courier new, monospace"> 17 | 5 | 2013</font></div>
<div><font face="courier new, monospace"> 29 | 6 | 2013</font></div>
<div><font face="courier new, monospace"> 18 | 7 | 2013</font></div>
<div><font face="courier new, monospace"> 34 | 8 | 2013</font></div>
<div><font face="courier new, monospace"> 25 | 9 | 2013</font></div>
<div><font face="courier new, monospace"> 28 | 10 | 2013</font></div>
<div><font face="courier new, monospace"> 30 | 11 | 2013</font></div>
<div><font face="courier new, monospace"> 7 | 12 | 2013</font></div>
<div><font face="courier new, monospace"> 21 | 1 | 2014</font></div>
<div><font face="courier new, monospace"> 20 | 2 | 2014</font></div>
<div><font face="courier new, monospace"> 15 | 3 | 2014</font></div>
<div><font face="courier new, monospace"> 6 | 4 | 2014</font></div>
<div><font face="courier new, monospace"> 9 | 5 | 2014</font></div>
<div><font face="courier new, monospace"> 6 | 6 | 2014</font></div>
<div><font face="courier new, monospace"> 9 | 7 | 2014</font></div>
<div><font face="courier new, monospace"> 11 | 8 | 2014</font></div>
<div><font face="courier new, monospace"> 14 | 9 | 2014</font></div>
<div><font face="courier new, monospace"> 14 | 10 | 2014</font></div>
</div>
<div><font face="courier new, monospace"> </font></div>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div dir="ltr">
<div class="gmail_extra"><font face="courier new, monospace"><br><span class="">
<div class="gmail_quote">
<div>
<div>On Sat, Nov 1, 2014 at 3:33 AM, Roland Schulz <span dir="ltr"><<a href="mailto:roland@utk.edu" target="_blank">roland@utk.edu</a>></span> wrote:<br>
</div>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div>
<div dir="ltr">
<div>I was curious about our monthly activity and made the below graph. Maybe someone else finds it interesting. </div>
<div>Shows is:</div>
<div>- Number of changes. Includes all projects (e.g. also regressiontests) and all statuses (e.g. draft)</div>
<div>- Number of patchsets. Also includes all. Shown on right axis.</div>
<div>- Number of comments. Excludes comments by Jenkins or the patch author. Shown on right</div>
<div><br>
</div>
<img src="cid:ii_14968fa0c0a3a528" alt="Inline image 2" width="481" height="289"><span><font color="#888888"><br>
-- <br>
<div>ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov" target="_blank">
cmb.ornl.gov</a><br>
<a href="tel:865-241-1537" value="+18652411537" target="_blank">865-241-1537</a>, ORNL PO BOX 2008 MS6309</div>
</font></span></div>
<br>
</div>
</div>
<span><font color="#888888">--<br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to
<a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.<br>
</font></span></blockquote>
</div>
<br>
</span></font></div>
</div>
</div>
</blockquote>
</div><span class=""><font face="courier new, monospace">
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div>ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov" target="_blank">
cmb.ornl.gov</a><br>
<a href="tel:865-241-1537" value="+18652411537" target="_blank">865-241-1537</a>, ORNL PO BOX 2008 MS6309</div>
</font></span></div>
</div>
</div>
</blockquote></div><font face="courier new, monospace"><br><br clear="all"></font><div><font face="courier new, monospace"><br></font></div><font face="courier new, monospace">-- <br></font><div class="gmail_signature"><font face="courier new, monospace">ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov">cmb.ornl.gov</a><br>865-241-1537, ORNL PO BOX 2008 MS6309</font></div>
</div></div>