<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
<br>
I fixed the formatting of line 2491 of
src/gromacs/domdec/domdec.cpp in:<br>
<a class="moz-txt-link-freetext" href="https://gerrit.gromacs.org/#/c/4192/31">https://gerrit.gromacs.org/#/c/4192/31</a><br>
<br>
I am running the latest release of uncrustify: version 0.60.<br>
<br>
Cheers,<br>
<br>
Berk<br>
<br>
On 12/03/2014 10:24 AM, Roland Schulz wrote:<br>
</div>
<blockquote
cite="mid:CAO2TwbkSdckhhYca_OAb+S8+xeCUgkVt+soJATzDT6k8t+2Ndw@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div dir="ltr">Hi,
<div><br>
</div>
<div>which patch and what line number? We could check whether it
is fixed in the git master version of uncrustify.</div>
<div><br>
</div>
<div>Roland</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Dec 3, 2014 at 4:14 AM, Berk
Hess <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:hess@kth.se" target="_blank">hess@kth.se</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I just fixed a formatting issue in domdec.cpp:<br>
if ((comm->cell_f1[d] -
comm->cell_f_max0[d])*bfac < limit ||<br>
! (comm->cell_f0[d] -
comm->cell_f_min1[d])*bfac > -limit)<br>
<br>
if ((comm->cell_f1[d] -
comm->cell_f_max0[d])*bfac < limit ||<br>
! (comm->cell_f0[d]<br>
<br>
I was already wondering why uncrustify on Jenkins didn't
complain about<br>
the formatting, but I now found out that that's because
uncrustify<br>
generates the incorrect formatting. Is this a known bug?
What should I<br>
do with my patch, format it incorrectly on purpose?<br>
<br>
Cheers,<br>
<br>
Berk<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a
moz-do-not-send="true"
href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List"
target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a>
before posting!<br>
<br>
* Can't post? Read <a moz-do-not-send="true"
href="http://www.gromacs.org/Support/Mailing_Lists"
target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a moz-do-not-send="true"
href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers"
target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a>
or send a mail to <a moz-do-not-send="true"
href="mailto:gmx-developers-request@gromacs.org">gmx-developers-request@gromacs.org</a>.<br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature">ORNL/UT Center for Molecular
Biophysics <a moz-do-not-send="true"
href="http://cmb.ornl.gov">cmb.ornl.gov</a><br>
865-241-1537, ORNL PO BOX 2008 MS6309</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</body>
</html>