<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 3, 2014 at 4:36 AM, Berk Hess <span dir="ltr"><<a href="mailto:hess@kth.se" target="_blank">hess@kth.se</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hi,<br>
<br>
I fixed the formatting of line 2491 of src/gromacs/domdec/domdec.cpp in:<br>
<a href="https://gerrit.gromacs.org/#/c/4192/31" target="_blank">https://gerrit.gromacs.org/#/c/4192/31</a><br>
<br>
I am running the latest release of uncrustify: version 0.60.<br></div></div></blockquote><div><br></div><div>I tried it with the latest git master version of uncrustify and it doesn't change the behavior. I think all we can do is file a bug with them (<a href="https://github.com/bengardner/uncrustify/issues">https://github.com/bengardner/uncrustify/issues</a>) and leave the wrong indententation until the bug is fixed.</div><div><br></div><div>Roland</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div>
<br>
Cheers,<br>
<br>
Berk<div><div class="h5"><br>
<br>
On 12/03/2014 10:24 AM, Roland Schulz wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>which patch and what line number? We could check whether it is fixed in the git master version of uncrustify.</div>
<div><br>
</div>
<div>Roland</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Dec 3, 2014 at 4:14 AM, Berk Hess <span dir="ltr">
<<a href="mailto:hess@kth.se" target="_blank">hess@kth.se</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hi,<br>
<br>
I just fixed a formatting issue in domdec.cpp:<br>
if ((comm->cell_f1[d] - comm->cell_f_max0[d])*bfac < limit ||<br>
! (comm->cell_f0[d] - comm->cell_f_min1[d])*bfac > -limit)<br>
<br>
if ((comm->cell_f1[d] - comm->cell_f_max0[d])*bfac < limit ||<br>
! (comm->cell_f0[d]<br>
<br>
I was already wondering why uncrustify on Jenkins didn't complain about<br>
the formatting, but I now found out that that's because uncrustify<br>
generates the incorrect formatting. Is this a known bug? What should I<br>
do with my patch, format it incorrectly on purpose?<br>
<br>
Cheers,<br>
<br>
Berk<br>
<span><font color="#888888"><br>
--<br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" target="_blank">
http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to
<a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.<br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div>ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov" target="_blank">
cmb.ornl.gov</a><br>
<a href="tel:865-241-1537" value="+18652411537" target="_blank">865-241-1537</a>, ORNL PO BOX 2008 MS6309</div>
</div>
<br>
<fieldset></fieldset> <br>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov">cmb.ornl.gov</a><br>865-241-1537, ORNL PO BOX 2008 MS6309</div>
</div></div>