<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Hi David!</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">5.1 is closed since Mark released the beta, only direct bug-fixes go there!</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">There are two categories of C++ stuff:</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">1) Mere translation of old C files, but fixing them to be C++-compliant and avoid all warnings with the c++ static analyzer and cppcheck. These changes can touch several files, but the do not change any functionality and should be very easy to review. The main reason for these bulk moves is to make it possible to do more real C++ translation (which we can’t do when there are still C files that also need to use the functionality).</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">2) Teemu’s refactorization. This is real C++ stuff :-) Unfortunately I haven’t done as much there, but I’m working on it…</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">As for patches in general, I think we should stop thinking in terms of changes that “must” go in any particular release (or date) - as people review things we’ll eventually get to states where several developers think a change is ready to go in, and that’s when it happens. That per se is a strong incentive to write shorter changes (which I should know, since some of the large ones are my fault…)</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Cheers,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Erik</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div> <div class="airmail_ext_on" style="color:black"><br>From: <span style="color:black">David van der Spoel</span> <a href="mailto:spoel@xray.bmc.uu.se"><spoel@xray.bmc.uu.se></a><br>Reply: <span style="color:black">gmx-developers@gromacs.org</span> <a href="mailto:gmx-developers@gromacs.org"><gmx-developers@gromacs.org>></a><br>Date: <span style="color:black">23 Jul 2015 at 22:05:58</span><br>To: <span style="color:black">gmx-developers@gromacs.org</span> <a href="mailto:gmx-developers@gromacs.org"><gmx-developers@gromacs.org>></a><br>Subject: <span style="color:black"> [gmx-developers] Patch bonanza at gerrit. How to merge all that stuff? <br></span></div><br> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Hi,
<br>
<br>it seems like Erik and Teemu are working on a big C++ overhaul of many
<br>low level and old code. This is great and long overdue. However, the
<br>amount of patches is rather overwhelming, there are more than 100 open
<br>patches from 2015 in gerrit right now, and many patches are related to
<br>each other.
<br>
<br>Is there a way that we can facilitate merging patches without
<br>jeopardizing quality of the commits? For instance it is not trivial
<br>where one should start commenting? How do we decide what goes into 5.1
<br>and what doesn't or has that been decided already?
<br>
<br>Cheers,
<br>--
<br>David van der Spoel, Ph.D., Professor of Biology
<br>Dept. of Cell & Molec. Biol., Uppsala University.
<br>Box 596, 75124 Uppsala, Sweden. Phone: +46184714205.
<br>spoel@xray.bmc.uu.se http://folding.bmc.uu.se
<br>--
<br>Gromacs Developers mailing list
<br>
<br>* Please search the archive at http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before posting!
<br>
<br>* Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
<br>
<br>* For (un)subscribe requests visit
<br>https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers or send a mail to gmx-developers-request@gromacs.org.
<br></div></div></span></blockquote> <div id="bloop_sign_1437692571836907776" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px">-- <br><span style="font-family: 'helvetica Neue', helvetica;">Erik Lindahl <</span><a href="mailto:erik.lindahl@gmail.com" style="font-family: 'helvetica Neue', helvetica;">erik.lindahl@gmail.com</a><span style="font-family: 'helvetica Neue', helvetica;">> </span><br style="font-family: 'helvetica Neue', helvetica;"><span style="font-family: 'helvetica Neue', helvetica;">Professor of Biophysics, Dept. Biochemistry & Biophysics, Stockholm </span><span style="font-family: 'helvetica Neue', helvetica;">University </span><br style="font-family: 'helvetica Neue', helvetica;"><span style="font-family: 'helvetica Neue', helvetica;">Professor of Theoretical biophysics, Dept. Theoretical Physics, Royal Inst. </span><span style="font-family: 'helvetica Neue', helvetica;">Technology </span><br style="font-family: 'helvetica Neue', helvetica;"><span style="font-family: 'helvetica Neue', helvetica;">Science for Life Laboratory, Box 1031, 17121 Solna, Sweden</span></div></div></body></html>