<div dir="ltr">Hi,<div><br></div><div>Dominik, any contribution should be posted to <a href="http://gerrit.gromacs.org">gerrit.gromacs.org</a>. The current situation would only cause a problem if an application tried to link both to libgromacs and liblmfit correct? Because we don't have the lmfit API as public (but we currently still export all symbols so this currently only affects that the headers aren't installed).</div><div><br></div><div>David, why did you change the source style for those files (e.g. brackets, doxygen, ...)? I think for any external code, we want to keep files as close to the original as possible to be able to look at the difference and also be able to update to a newer version if needed. I think if there is no special reason why this is needed we should undo those style changes.</div><div><br></div><div>Roland</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 23, 2015 at 7:43 PM, Dominik 'Rathann' Mierzejewski <span dir="ltr"><<a href="mailto:dominik@greysector.net" target="_blank">dominik@greysector.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dear Developers,<br>
I am the maintainer of the GROMACS package in Fedora. Recently, I found<br>
that GROMACS bundles the lmfit library<br>
(<a href="http://apps.jcns.fz-juelich.de/doku/sc/lmfit" rel="noreferrer" target="_blank">http://apps.jcns.fz-juelich.de/doku/sc/lmfit</a>), which is already packaged<br>
in Fedora (<a href="https://apps.fedoraproject.org/packages/lmfit" rel="noreferrer" target="_blank">https://apps.fedoraproject.org/packages/lmfit</a>). However, it<br>
seems that the GROMACS-included version is modified from latest 5.1<br>
version (cleaned-up patch showing the main differences attached) and in<br>
a bad way: it breaks API and ABI (lmcurve_evaluate() and lmcurve()).<br>
<br>
Now, this can be done properly by introducing new API that GROMACS can<br>
use while keeping the existing API intact. To that end, I'm attaching<br>
a patch that tries to do just that. I'm not claiming my solution is the<br>
best or even entirely correct, but it should be a start.<br>
<br>
I'm also attaching an initial patch for GROMACS to use a system-wide<br>
shared library with this new API. It's most probably not suitable<br>
to be applied as-is, but at least the internal test suite (make check)<br>
passes.<br>
<br>
I'm Cc'ing other interested parties, including the Fedora lmfit package<br>
maintainer (Miro), the lmfit author (Joachim Wuttke) and Tobias Klauser,<br>
who seems to have created a fork of lmfit on github<br>
(<a href="https://github.com/tklauser/lmfit" rel="noreferrer" target="_blank">https://github.com/tklauser/lmfit</a>) which contains at least one fix<br>
present in GROMACS fork of lmfit, too (the memleak fix:<br>
<a href="https://github.com/tklauser/lmfit/commit/1dfe71ae26986b52e6037fb1933904d541ab100f" rel="noreferrer" target="_blank">https://github.com/tklauser/lmfit/commit/1dfe71ae26986b52e6037fb1933904d541ab100f</a>).<br>
<br>
Regards,<br>
Dominik<br>
<span class="HOEnZb"><font color="#888888">--<br>
Fedora <a href="http://fedoraproject.org/wiki/User:Rathann" rel="noreferrer" target="_blank">http://fedoraproject.org/wiki/User:Rathann</a><br>
RPMFusion <a href="http://rpmfusion.org" rel="noreferrer" target="_blank">http://rpmfusion.org</a><br>
"Faith manages."<br>
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">ORNL/UT Center for Molecular Biophysics <a href="http://cmb.ornl.gov" target="_blank">cmb.ornl.gov</a><br>865-241-1537, ORNL PO BOX 2008 MS6309</div>
</div>