<div dir="ltr">Hi,<div><br></div><div>It could help a bit, particularly with giving people more ability to feel confident in reviewing the code without having to do a full checkout. However, if the patch under review changes aspects of the API, how does that work? Relying on a nightly build for the infrastructure behind the click-to-jump-to-definition seems like it might have too much friction.</div><div><br></div><div>People with less experience of the code base than me should particularly speak up here. :-) You're the market where this has a large impact.</div><div><br></div><div>Mark</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Feb 1, 2017 at 1:58 AM Schulz, Roland <<a href="mailto:roland.schulz@intel.com">roland.schulz@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br class="gmail_msg">
<br class="gmail_msg">
As I mentioned on the last developer call, there is a code browser and Gerrit integration available. One can click on a function in Gerrit to go the definition and usages. It is available in the QT Gerrit and it looks like <a href="http://imgur.com/Q3a2ixz" rel="noreferrer" class="gmail_msg" target="_blank">http://imgur.com/Q3a2ixz</a> . The links go to <a href="https://code.woboq.org/qt5/qtbase/src/corelib/io/qurl.cpp.html#_ZN4QUrl13fromLocalFileERK7QString" rel="noreferrer" class="gmail_msg" target="_blank">https://code.woboq.org/qt5/qtbase/src/corelib/io/qurl.cpp.html#_ZN4QUrl13fromLocalFileERK7QString</a> and <a href="https://code.woboq.org/data/symbol.html?root=../qt5/&ref=_ZN4QUrl13fromLocalFileERK7QString#uses" rel="noreferrer" class="gmail_msg" target="_blank">https://code.woboq.org/data/symbol.html?root=../qt5/&ref=_ZN4QUrl13fromLocalFileERK7QString#uses</a><br class="gmail_msg">
<br class="gmail_msg">
It can be tried out on <a href="https://codereview.qt-project.org" rel="noreferrer" class="gmail_msg" target="_blank">https://codereview.qt-project.org</a> after installing <a href="https://code.woboq.org/qt-gerrit.user.js" rel="noreferrer" class="gmail_msg" target="_blank">https://code.woboq.org/qt-gerrit.user.js</a> which requires Greasmonkey for Firefox / Tampermonkey for Chrome. A bit more detail about the integration is at <a href="http://lists.qt-project.org/pipermail/development/2016-May/025733.html" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.qt-project.org/pipermail/development/2016-May/025733.html</a> and the about the code browser at <a href="https://woboq.com/codebrowser.html" rel="noreferrer" class="gmail_msg" target="_blank">https://woboq.com/codebrowser.html</a> .<br class="gmail_msg">
<br class="gmail_msg">
Do you think this would help with productivity in code review making it worth taking the time installing it? The installation instructions are at <a href="https://github.com/woboq/woboq_codebrowser/blob/master/README.md" rel="noreferrer" class="gmail_msg" target="_blank">https://github.com/woboq/woboq_codebrowser/blob/master/README.md</a><br class="gmail_msg">
<br class="gmail_msg">
Roland<br class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
Gromacs Developers mailing list<br class="gmail_msg">
<br class="gmail_msg">
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" rel="noreferrer" class="gmail_msg" target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br class="gmail_msg">
<br class="gmail_msg">
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" rel="noreferrer" class="gmail_msg" target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br class="gmail_msg">
<br class="gmail_msg">
* For (un)subscribe requests visit<br class="gmail_msg">
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" rel="noreferrer" class="gmail_msg" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" class="gmail_msg" target="_blank">gmx-developers-request@gromacs.org</a>.<br class="gmail_msg">
</blockquote></div>