<div dir="ltr">Hi,<div><br></div><div>IIRC there's a gerrit option that determines whether a no-conflict rebase requires a verification vote (which we implement with Jenkins). I don't know of a way to run the Jenkins pre-submit matrix after the submission of such a patch, and not on a patch that didn't need a rebase (which would be wasteful). So the options are to always require a verification (which will slow things down for those who are active in coordinating submitting patches, and those who are waiting for verifications), or to continue to accept that life is sometimes messy and a master branch HEAD that fails to pass Jenkins every few hundred patches or so is pretty good, really.</div><div><br></div><div>Mark</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 21, 2017 at 9:11 PM Szilárd Páll <<a href="mailto:pall.szilard@gmail.com">pall.szilard@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Could we tweak the gerrit config to redo the pre-submit verification upon clear rebase prior to submission? I understand that we chose to take the moderate risk of ending up with broken verification (as clean rebase =/=> +2 verify), but we should at least try to rerun the pre-submit tests and post its results after the fact.</div><div><br></div><div>It would not eliminate false positive -2 Verifie's, but would at least help avoiding confusion.</div><div><br></div><div>Concrete case (I think) which luckily did get caught in post-submit: <a href="https://gerrit.gromacs.org/#/c/7174/" target="_blank">https://gerrit.gromacs.org/#/c/7174/</a></div><div><a href="http://jenkins.gromacs.org/view/Post-submit/job/Gromacs_PostSubmit_master/334/" target="_blank">http://jenkins.gromacs.org/view/Post-submit/job/Gromacs_PostSubmit_master/334/</a><br></div><div><div><br></div><div>Cheers,</div><div><div><div class="m_-5035557281063368148gmail_signature">--<br>Szilárd</div></div>
</div>
</div></div>
--<br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" rel="noreferrer" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.</blockquote></div>