Hi,<div><br></div><div>I'm sure there are ways to improve things here, and the more important thing is to write words than worry about where to host them. Do note that there are things in the developer guide in the source repo, which we should not duplicate!</div><div><br></div><div>Marm<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 31, 2018, 12:56 Kevin Boyd <<a href="mailto:kevin.boyd@uconn.edu">kevin.boyd@uconn.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" id="gmail_block_quote0"><div dir="ltr"><div dir="auto">Hi,<div><br></div><div>As someone who just recently started, I agree that porting the info on getting started with gerrit is worth it - I found the webpage quite helpful, but I wasn’t sure if it was up-to-date, so I was hesitant to try out the commands in the instructions.</div><div><br></div><div>I also agree with Joe’s comment on uncrustify. The "Automatic Source Control" section could benefit from an example of how to use uncrustify manually (particularly in reference to a configuration file), and maybe a little clarification on configuring it to run automatically.<br><br>I'd like to throw in that it might be useful (particularly for someone like me who hasn't really contributed to open source projects in the past) to include an overview of the development process, such as is found here:</div><div><a href="http://www.gromacs.org/Developer_Zone/Developer_Workflow" target="_blank">http://www.gromacs.org/Developer_Zone/Developer_Workflow</a><br><br>I'd be happy to port those pages to the manual if others agree!<br><br><div id="m_-3754600431002850802gmail-m_8113528667441658837AppleMailSignature">Kevin</div></div></div></div><div dir="ltr"><div dir="auto"><div><div><br>On Jul 31, 2018, at 4:31 AM, Joe Jordan <<a href="mailto:e.jjordan12@gmail.com" target="_blank">e.jjordan12@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">My two cents would be that it would be better to port than link. The feel of the gerrit page is very 2004. Additionally it could benefit from having the example code snippets code highlighted in the currently standard code boxes. I personally had a hard time when I was starting developing figuring out how to work with gerrit and uncrustify, so I think these sections could also use some copy editing that I would be happy to contribute to. <div><br></div><div>As a constructive example, <div><br></div><div>
<pre style="margin:0.5em 0px 0.5em 1em;padding:0px 0px 0px 1em;color:rgb(119,119,119);border-left:4px solid rgb(170,170,170);background-color:rgb(254,254,254);overflow:visible;font-size:12px;text-decoration-style:initial;text-decoration-color:initial">git clone ssh://<span style="color:rgb(255,0,0)"><strong style="font-style:normal;font-weight:bold">USER</strong></span>@<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgerrit.gromacs.org%2Fgromacs.git&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234542281&sdata=SMBvc%2F0LmUyQF3Yg24Vxl4Dh20rs5TWMXxYLJsi4TLI%3D&reserved=0" target="_blank">gerrit.gromacs.org/gromacs.git</a></pre>
</div><div>
<pre style="margin:0.5em 0px 0.5em 1em;padding:0px 0px 0px 1em;color:rgb(119,119,119);border-left:4px solid rgb(170,170,170);background-color:rgb(254,254,254);overflow:visible;font-size:12px;text-decoration-style:initial;text-decoration-color:initial">git remote set-url origin ssh://<span style="color:rgb(255,0,0)"><strong style="font-style:normal;font-weight:bold">USER</strong></span>@<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgerrit.gromacs.org%2Fgromacs.git&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234542281&sdata=SMBvc%2F0LmUyQF3Yg24Vxl4Dh20rs5TWMXxYLJsi4TLI%3D&reserved=0" target="_blank">gerrit.gromacs.org/gromacs.git</a></pre>
<pre style="margin:0.5em 0px 0.5em 1em;padding:0px 0px 0px 1em;color:rgb(119,119,119);border-left:4px solid rgb(170,170,170);background-color:rgb(254,254,254);overflow:visible;font-size:12px;text-decoration-style:initial;text-decoration-color:initial">git remote add upload ssh://<span style="color:rgb(255,0,0)"><strong style="font-style:normal;font-weight:bold">USER</strong></span>@<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgerrit.gromacs.org%2Fgromacs.git&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234552291&sdata=t4uHho3t2IYkkf0SMhVVsnC3hY0VkE6hZedyyYZPC2I%3D&reserved=0" target="_blank">gerrit.gromacs.org/gromacs.git</a></pre>
<pre style="margin:0.5em 0px 0.5em 1em;padding:0px 0px 0px 1em;color:rgb(119,119,119);border-left:4px solid rgb(170,170,170);background-color:rgb(254,254,254);overflow:visible;font-size:12px;text-decoration-style:initial;text-decoration-color:initial">scp -p <span style="color:rgb(255,0,0)"><strong style="font-style:normal;font-weight:bold">USER</strong></span>@gerrit.gromacs.org:hooks/commit-msg .git/hooks/</pre>
<br></div><div>could be one (line numbered) code block with text explaining each line. This way users could copy it directly into a script to run whenever the want to fetch a new gromacs source instance.</div></div><div><br></div><div>As for uncrustify, it would be helpful both to mention that uncrustify is a script in the admin folder that you can run, since I (and one other newbie I talked to) had a hard time figuring this out. It could also be good to have a code listing and explanation of the actual uncrustify command that gerrit runs, in addition to a code listing for how to fix uncrustify errors using reformat_all (which is currently lacking).</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 30, 2018 at 7:10 PM, Eric Irrgang <span dir="ltr"><<a href="mailto:ericirrgang@gmail.com" target="_blank">ericirrgang@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi All,<br>
<br>
I would like to either port<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FDeveloper_Zone%2FGit%2FGerrit&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234552291&sdata=GzhreisGhqHM1WD%2FFwJSPpDPVXEg0jkTwIkR1%2FB9vFc%3D&reserved=0" rel="noreferrer" target="_blank">http://www.gromacs.org/Developer_Zone/Git/Gerrit</a> or link to it from<br>
the (new) "Contributing" section of the Developer Guide.<br>
<br>
I remember some discussion about the sorts of documentation that<br>
should live in the repository versus somewhere else, and I think the<br>
upshot was that things like advice on using Gerrit don't belong in the<br>
primary repository, but I could be misremembering because<br>
Understanding Jenkins Builds is in there.<br>
<br>
So my thought is to at least link to the old content in<br>
Developer_Guide/Developmen-time_tools/Change_management and in<br>
Developer_Guide/Contribute_to_GROMACS<br>
<br>
My question is whether to link to the old content or port that page to<br>
the new dev-manual. Thoughts?<br>
<br>
Thanks,<br>
Eric<br>
<span class="m_-3754600431002850802gmail-m_8113528667441658837HOEnZb"><font color="#888888">-- <br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists%2FGMX-developers_List&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234562296&sdata=pZ26sC2tbhsDr03gPP3laAM7Q%2FBQB5lF5I7DxyehmWM%3D&reserved=0" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234562296&sdata=a2hl%2F6OnVawo5nRTXRjrUC5LYj6ywydZvKW0p1xYEPM%3D&reserved=0" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmaillist.sys.kth.se%2Fmailman%2Flistinfo%2Fgromacs.org_gmx-developers&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234572300&sdata=WdFefbk7rqPi68SW2E2Onu9oU7ow2RozrF6DM8Dj%2BW8%3D&reserved=0" rel="noreferrer" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-3754600431002850802gmail-m_8113528667441658837gmail_signature"><div dir="ltr"><div><div dir="ltr">Joe Jordan<br><div><br></div></div></div></div></div>
</div>
</div></blockquote></div></div></div><div dir="ltr"><div dir="auto"><div><blockquote type="cite"><div><span>-- </span><br><span>Gromacs Developers mailing list</span><br><span></span><br></div></blockquote></div></div></div><div dir="ltr"><div dir="auto"><div><blockquote type="cite"><div><span>* Please search the archive at <a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists%2FGMX-developers_List&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=2xbrVYyZ%2FDdA8oyqvQmQ9Ic1mI%2FPIPxsmWd96i6HljU%3D&amp;reserved=0" target="_blank">https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists%2FGMX-developers_List&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=2xbrVYyZ%2FDdA8oyqvQmQ9Ic1mI%2FPIPxsmWd96i6HljU%3D&amp;reserved=0</a> before posting!</span><br><span></span><br><span>* Can't post? Read <a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=X30gtkdD0u3MXr0M2fly5f9FQzekTy0uO1Vt8kPJjgE%3D&amp;reserved=0" target="_blank">https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=X30gtkdD0u3MXr0M2fly5f9FQzekTy0uO1Vt8kPJjgE%3D&amp;reserved=0</a></span></div></blockquote></div></div></div><div dir="ltr"><div dir="auto"><div><blockquote type="cite"><div><br><span></span><br><span>* For (un)subscribe requests visit</span><br></div></blockquote></div></div></div><div dir="ltr"><div dir="auto"><div><blockquote type="cite"><div><span><a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmaillist.sys.kth.se%2Fmailman%2Flistinfo%2Fgromacs.org_gmx-developers&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=50%2FxSFa9RwFqundMKoGlk%2B2HoT0fVqf7JTLB7AX%2BNH4%3D&amp;reserved=0" target="_blank">https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmaillist.sys.kth.se%2Fmailman%2Flistinfo%2Fgromacs.org_gmx-developers&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=50%2FxSFa9RwFqundMKoGlk%2B2HoT0fVqf7JTLB7AX%2BNH4%3D&amp;reserved=0</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.</span></div></blockquote></div></div></div>
-- <br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" rel="noreferrer" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.</blockquote></div></div>