<div dir="ltr">Hi,<div><br></div><div>No. gcc 4 isn't supported in master branch - that's just crappy output from the Jenkins plugin that scrapes warnings from the compiler console output. <a href="https://gerrit.gromacs.org/#/c/9248/">https://gerrit.gromacs.org/#/c/9248/</a> reports which config fails.</div><div><br></div><div>Mark</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 5 Mar 2019 at 14:04 Berk Hess <<a href="mailto:hess@kth.se">hess@kth.se</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_1034256159709637476moz-cite-prefix">Hi,<br>
<br>
The post-submit build that complains seems to use gcc-4.</div></div><div text="#000000" bgcolor="#FFFFFF"><div class="m_1034256159709637476moz-cite-prefix"><br>
<br>
Berk</div></div><div text="#000000" bgcolor="#FFFFFF"><div class="m_1034256159709637476moz-cite-prefix"><br>
<br>
On 05/03/2019 14.01, Mark Abraham wrote:<br>
</div></div><div text="#000000" bgcolor="#FFFFFF">
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>Ah, I see that that warning is also in at least clang 6,
and that's only used in the clang_cuda post-submit. There's
probably not enough value in converting a pre-submit config
with clang to build with CUDA support (even though e.g. CUDA
9.2 supports clang 5 natively), but if we just suppress the
warning, then we'll handle the issue in advance of when a CUDA
version supports gcc 8 (which we would test in pre-submit). Or
we could add OpenCL support to the asan or tsan build with
clang-7, which is a stone that might kill other birds...</div>
<div><br>
</div>
<div>Mark</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 5 Mar 2019 at 13:43
Mark Abraham <<a href="mailto:mark.j.abraham@gmail.com" target="_blank">mark.j.abraham@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi,
<div><br>
</div>
<div>That behaviour was added to -Wall in gcc 8. I agree
that's something we don't need to warn about. We can
change cmake/CFlags.cmake to add -Wno-extra-semi to
suppress it.</div>
</div>
<div dir="ltr">
<div><br>
</div>
<div>Mark</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 5 Mar 2019 at
12:01 Berk Hess <<a href="mailto:hess@kth.se" target="_blank">hess@kth.se</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
A post submit build uses -Wextra-semi which gives warnings
that other <br>
builds don't give. If I understood corretly this warns for
someting that <br>
is allowed in C++11. Should we remove this flag?<br>
<br>
Cheers,<br>
<br>
Berk<br>
<br>
-- <br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a>
before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" rel="noreferrer" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a>
or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.<br>
</blockquote>
</div>
</blockquote>
</div>
<br>
<fieldset class="m_1034256159709637476mimeAttachmentHeader"></fieldset>
</blockquote>
<br>
</div>
-- <br>
Gromacs Developers mailing list<br>
<br>
* Please search the archive at <a href="http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List</a> before posting!<br>
<br>
* Can't post? Read <a href="http://www.gromacs.org/Support/Mailing_Lists" rel="noreferrer" target="_blank">http://www.gromacs.org/Support/Mailing_Lists</a><br>
<br>
* For (un)subscribe requests visit<br>
<a href="https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers" rel="noreferrer" target="_blank">https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers</a> or send a mail to <a href="mailto:gmx-developers-request@gromacs.org" target="_blank">gmx-developers-request@gromacs.org</a>.</blockquote></div>